• Sumit.Saxena@avagotech.com's avatar
    megaraid_sas : Update threshold based reply post host index register · db4fc864
    Sumit.Saxena@avagotech.com authored
    Resending the patch. Addressed the review comments from Tomas Henzl.
    
    Current driver updates reply post host index to let firmware know that replies are processed,
    while returning from ISR function, only if there is no oustanding replies in reply queue.
    
    Driver will free the request frame immediately from ISR but reply post host index is not yet updated.
    It means freed request can be used by submission path and there may be a tight loop in request/reply
    path. In such condition, firmware may crash when it tries to post reply and there is no free
    reply post descriptor.
    
    Eventually two things needs to be change to avoid this issue.
    
    Increase reply queue depth (double than request queue) to accommodate worst case scenario.
    Update reply post host index to firmware once it reach to some pre-defined threshold value.
    
    This change will make sure that firmware will always have some buffer of reply descriptor and
    will never find empty reply descriptor in completion path.
    Signed-off-by: default avatarSumit Saxena <sumit.saxena@avagotech.com>
    Signed-off-by: default avatarKashyap Desai <kashyap.desai@avagotech.com>
    Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    db4fc864
megaraid_sas_fusion.h 24.3 KB