• Christian Lamparter's avatar
    um: fix default console kernel parameter · 782b1f70
    Christian Lamparter authored
    OpenWrt's UML with 5.15 was producing odd errors/warnings during preinit
    part of the early userspace portion:
    
    |[    0.000000] Kernel command line: ubd0=root.img root=98:0 console=tty
    |[...]
    |[    0.440000] random: jshn: uninitialized urandom read (4 bytes read)
    |[    0.460000] random: jshn: uninitialized urandom read (4 bytes read)
    |/etc/preinit: line 47: can't create /dev/tty: No such device or address
    |/etc/preinit: line 48: can't create /dev/tty: No such device or address
    |/etc/preinit: line 58: can't open /dev/tty: No such device or address
    |[...] repeated many times
    
    That "/dev/tty" came from the command line (which is automatically
    added if no console= parameter was specified for the uml binary).
    
    The TLDP project tells the following about the /dev/tty:
    <https://tldp.org/HOWTO/Text-Terminal-HOWTO-7.html#ss7.3>
    | /dev/tty stands for the controlling terminal (if any) for the current
    | process.[...]
    | /dev/tty is something like a link to the actually terminal device[..]
    
    The "(if any)" is important here, since it's possible for processes to
    not have a controlling terminal.
    
    I think this was a simple typo and the author wanted tty0 there.
    
    CC: Thomas Meyer <thomas@m3y3r.de>
    Fixes: d7ffac33 ("um: stdio_console: Make preferred console")
    Signed-off-by: default avatarChristian Lamparter <chunkeey@gmail.com>
    Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
    782b1f70
um_arch.c 11.8 KB