• Darrick J. Wong's avatar
    libata: fix double-completion on error · 253b92ec
    Darrick J. Wong authored
    A curious thing happens, however, when ata_qc_new_init fails to get
    an ata_queued_cmd:
    
    First, ata_qc_new_init handles the failure like this:
        cmd->result = (DID_OK << 16) | (QUEUE_FULL << 1);
        done(cmd);
    
    Then, we return to ata_scsi_translate and do this:
        err_mem:
            cmd->result = (DID_ERROR << 16);
            done(cmd);
    
    It appears to me that first we set a status code indicating that we're
    ok but the device queue is full and finish the command,  but then
    we blow away that status code and replace it with an error flag and
    finish the command a second time!  That does not seem to be desirable
    behavior since we merely want the I/O to wait until a command slot
    frees up, not send errors up the block layer.
    
    In the err_mem case, we should simply exit out of ata_scsi_translate
    instead.
    Signed-off-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
    Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
    253b92ec
libata-scsi.c 83.6 KB