• Quentin Casasnovas's avatar
    cdc-acm: prevent infinite loop when parsing CDC headers. · 0d3bba02
    Quentin Casasnovas authored
    Phil and I found out a problem with commit:
    
      7e860a6e ("cdc-acm: add sanity checks")
    
    It added some sanity checks to ignore potential garbage in CDC headers but
    also introduced a potential infinite loop.  This can happen at the first
    loop iteration (elength = 0 in that case) if the description isn't a
    DT_CS_INTERFACE or later if 'buffer[0]' is zero.
    
    It should also be noted that the wrong length was being added to 'buffer'
    in case 'buffer[1]' was not a DT_CS_INTERFACE descriptor, since elength was
    assigned after that check in the loop.
    
    A specially crafted USB device could be used to trigger this infinite loop.
    
    Fixes: 7e860a6e ("cdc-acm: add sanity checks")
    Signed-off-by: default avatarPhil Turnbull <phil.turnbull@oracle.com>
    Signed-off-by: default avatarQuentin Casasnovas <quentin.casasnovas@oracle.com>
    CC: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    CC: Oliver Neukum <oneukum@suse.de>
    CC: Adam Lee <adam8157@gmail.com>
    CC: <stable@vger.kernel.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    0d3bba02
cdc-acm.c 51.3 KB