• Peter Hurley's avatar
    tty: Move tty->closing from port lock critical section · ddc7b758
    Peter Hurley authored
    tty->closing informs the line discipline that the hardware will
    be shutting down imminently, and to disable further input other
    than soft flow control (but to still allow additional output).
    
    However, the tty lock is the necessary lock for preventing
    concurrent changes to tty->closing. As shown by the call-tree
    audit [1] of functions that modify tty->closing, the tty lock
    is already held for those functions.
    
    [1]
    Call-tree audit of functions that modify tty->closing
    * does not include call tree to tty_port_close(), tty_port_close_start(),
      or tty_port_close_end() which is already documented in
      'tty: Document locking for tty_port_close{,start,end}' that shows
      callers to those 3 functions hold the tty lock
    
    tty_release()
      tty->ops->close() --+
                          |
    __tty_hangup()        |
      tty->ops->close() --+
                          |
            mp_close():drivers/staging/sb105x/sb_pci_mp.c
            dngc_tty_close():drivers/staging/dgnc/dgnc_tty.c
            dgap_tty_close():drivers/staging/dgap/dgap_tty.c
            dgrp_tty_close():drivers/staging/dgrp/dgrp_tty.c
            rp_close():drivers/tty/rocket.c
            hvsi_close():drivers/tty/hvc/hvsi.c
            rs_close():drivers/tty/serial/68328serial.c
            rs_close():drivers/tty/serial/crisv10.c
            uart_close():drivers/tty/serial/serial_core.c
            isdn_tty_close():drivers/isdn/i4l/isdn_tty.c
            tty3215_close():drivers/s390/char/con3215.c
    
    tty_open()
      tty_ldisc_setup() ----+
                            |
    __tty_hangup()          |
      tty_ldisc_hangup() ---+
                            |
    tty_set_ldisc() --------+
      tty_ldisc_restore() --+
                            |
                            +- tty_ldisc_open()
                                 ld->ops->open() --+
                                                   |
                                                   +- n_tty_open()
    Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    ddc7b758
tty_port.c 16.2 KB