• Shane Huang's avatar
    libata: check SATA_SETTINGS log with HW Feature Ctrl · de90cd71
    Shane Huang authored
    NCQ capability was used to check availability of SATA Settings page
    from Identify Device Data Log, which contains DevSlp timing variables.
    It does not work on some HDDs and leads to error messages.
    IDENTIFY word 78 bit 5(Hardware Feature Control) should be used.
    
    Quoting SATA spec 3.1:
    If Hardware Feature Control is supported, then:
    a) IDENTIFY DEVICE data word 78 bit 5 (see 13.2.1.18) shall be
    set to one;
    b) the SET FEATURES Select Hardware Feature Control subcommand
    shall be supported (see 13.3.8);
    c) page 08h of the Identify Device Data log (see 13.7.7) shall
    be supported;
    
    This patch is not tested on SATA HDD with DevSlp supported.
    Reported-by: default avatarBorislav Petkov <bp@amd64.org>
    Signed-off-by: default avatarShane Huang <shane.huang@amd.com>
    Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
    de90cd71
libata-core.c 175 KB