• Sean Christopherson's avatar
    KVM: x86: Exempt pending triple fault from event injection sanity check · dea0d5a2
    Sean Christopherson authored
    Exempt pending triple faults, a.k.a. KVM_REQ_TRIPLE_FAULT, when asserting
    that KVM didn't attempt to queue a new exception during event injection.
    KVM needs to emulate the injection itself when emulating Real Mode due to
    lack of unrestricted guest support (VMX) and will queue a triple fault if
    that emulation fails.
    
    Ideally the assertion would more precisely filter out the emulated Real
    Mode triple fault case, but rmode.vm86_active is buried in vcpu_vmx and
    can't be queried without a new kvm_x86_ops.  And unlike "regular"
    exceptions, triple fault cannot put the vCPU into an infinite loop; the
    triple fault will force either an exit to userspace or a nested VM-Exit,
    and triple fault after nested VM-Exit will force an exit to userspace.
    I.e. there is no functional issue, so just suppress the warning for
    triple faults.
    
    Opportunistically convert the warning to a one-time thing, when it
    fires, it fires _a lot_, and is usually user triggerable, i.e. can be
    used to spam the kernel log.
    
    Fixes: 7055fb11 ("KVM: x86: Treat pending TRIPLE_FAULT requests as pending exceptions")
    Reported-by: default avatarkernel test robot <yujie.liu@intel.com>
    Link: https://lore.kernel.org/r/202209301338.aca913c3-yujie.liu@intel.comSigned-off-by: default avatarSean Christopherson <seanjc@google.com>
    Message-Id: <20220930230008.1636044-1-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    dea0d5a2
x86.c 365 KB