• Jiri Slaby's avatar
    Char: mxser, call pci_disable_device from probe/remove · df480518
    Jiri Slaby authored
    Vasiliy found that pci_disable_device is not called on fail paths in
    mxser_probe. Actually, it is called from nowhere in the driver.
    
    There are three changes needed:
    1) don't use pseudo-generic mxser_release_res. Let's use it only from
       ISA paths from now on. All the pci stuff is moved to probe and
       remove PCI-related functions.
    2) reorder fail-paths in the probe function so that it makes sense and
       we can call them from the sequential code naturally (the further we
       are the earlier label we go to).
    3) add pci_disable_device both to mxser_probe and mxser_remove.
    
    There is a nit of adding CONFIG_PCI ifdef to mxser_remove. it is
    because this driver supports ISA-only compilations and it would choke
    up on the newly added calls now.
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Cc: Kulikov Vasiliy <segooon@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    df480518
mxser.c 69.3 KB