• Mark Rutland's avatar
    arm64: fix rodata=full · 2e8cff0a
    Mark Rutland authored
    On arm64, "rodata=full" has been suppored (but not documented) since
    commit:
    
      c55191e9 ("arm64: mm: apply r/o permissions of VM areas to its linear alias as well")
    
    As it's necessary to determine the rodata configuration early during
    boot, arm64 has an early_param() handler for this, whereas init/main.c
    has a __setup() handler which is run later.
    
    Unfortunately, this split meant that since commit:
    
      f9a40b08 ("init/main.c: return 1 from handled __setup() functions")
    
    ... passing "rodata=full" would result in a spurious warning from the
    __setup() handler (though RO permissions would be configured
    appropriately).
    
    Further, "rodata=full" has been broken since commit:
    
      0d6ea3ac ("lib/kstrtox.c: add "false"/"true" support to kstrtobool()")
    
    ... which caused strtobool() to parse "full" as false (in addition to
    many other values not documented for the "rodata=" kernel parameter.
    
    This patch fixes this breakage by:
    
    * Moving the core parameter parser to an __early_param(), such that it
      is available early.
    
    * Adding an (optional) arch hook which arm64 can use to parse "full".
    
    * Updating the documentation to mention that "full" is valid for arm64.
    
    * Having the core parameter parser handle "on" and "off" explicitly,
      such that any undocumented values (e.g. typos such as "ful") are
      reported as errors rather than being silently accepted.
    
    Note that __setup() and early_param() have opposite conventions for
    their return values, where __setup() uses 1 to indicate a parameter was
    handled and early_param() uses 0 to indicate a parameter was handled.
    
    Fixes: f9a40b08 ("init/main.c: return 1 from handled __setup() functions")
    Fixes: 0d6ea3ac ("lib/kstrtox.c: add "false"/"true" support to kstrtobool()")
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
    Cc: Ard Biesheuvel <ardb@kernel.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Jagdish Gediya <jvgediya@linux.ibm.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Randy Dunlap <rdunlap@infradead.org>
    Cc: Will Deacon <will@kernel.org>
    Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
    Link: https://lore.kernel.org/r/20220817154022.3974645-1-mark.rutland@arm.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
    2e8cff0a
main.c 39.9 KB