• Arnd Bergmann's avatar
    scsi: NCR53c406a: avoid section mismatch with LTO · 80e6e9c1
    Arnd Bergmann authored
    Building with link time optimizations produces a false-positive section
    mismatch warning:
    
    WARNING: vmlinux.o(.data+0xf7e8): Section mismatch in reference from the variable driver_template.lto_priv.6914 to the function .init.text:NCR53c406a_detect()
    The variable driver_template.lto_priv.6914 references
    the function __init NCR53c406a_detect()
    If the reference is valid then annotate the
    variable with __init* or __refdata (see linux/init.h) or name the variable:
    *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
    
    The ->detect callback is always entered from the init_this_scsi_driver()
    init function, but apparently LTO turns the optimized direct function
    call into an indirect call through a non-__initdata pointer.
    
    All drivers using init_this_scsi_driver() are for ancient hardware, and
    most don't mark the detect() callback as __init(), so I'm just removing
    the annotation here to kill off the warning instead of doing a larger
    rework.
    
    [mkp: typo]
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    80e6e9c1
NCR53c406a.c 28 KB