• Pali Rohár's avatar
    cifs: Fix buffer overflow when parsing NFS reparse points · e2a8910a
    Pali Rohár authored
    ReparseDataLength is sum of the InodeType size and DataBuffer size.
    So to get DataBuffer size it is needed to subtract InodeType's size from
    ReparseDataLength.
    
    Function cifs_strndup_from_utf16() is currentlly accessing buf->DataBuffer
    at position after the end of the buffer because it does not subtract
    InodeType size from the length. Fix this problem and correctly subtract
    variable len.
    
    Member InodeType is present only when reparse buffer is large enough. Check
    for ReparseDataLength before accessing InodeType to prevent another invalid
    memory access.
    
    Major and minor rdev values are present also only when reparse buffer is
    large enough. Check for reparse buffer size before calling reparse_mkdev().
    
    Fixes: d5ecebc4
    
     ("smb3: Allow query of symlinks stored as reparse points")
    Reviewed-by: default avatarPaulo Alcantara (Red Hat) <pc@manguebit.com>
    Signed-off-by: default avatarPali Rohár <pali@kernel.org>
    Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
    e2a8910a
reparse.c 14.2 KB