• Adrian Hunter's avatar
    perf tools: Fix segfault accessing sample_id xyarray · a668cc07
    Adrian Hunter authored
    perf_evsel::sample_id is an xyarray which can cause a segfault when
    accessed beyond its size. e.g.
    
      # perf record -e intel_pt// -C 1 sleep 1
      Segmentation fault (core dumped)
      #
    
    That is happening because a dummy event is opened to capture text poke
    events accross all CPUs, however the mmap logic is allocating according
    to the number of user_requested_cpus.
    
    In general, perf sometimes uses the evsel cpus to open events, and
    sometimes the evlist user_requested_cpus. However, it is not necessary
    to determine which case is which because the opened event file
    descriptors are also in an xyarray, the size of whch can be used
    to correctly allocate the size of the sample_id xyarray, because there
    is one ID per file descriptor.
    
    Note, in the affected code path, perf_evsel fd array is subsequently
    used to get the file descriptor for the mmap, so it makes sense for the
    xyarrays to be the same size there.
    
    Fixes: d1a17759 ("libperf: Adopt perf_evlist__mmap()/munmap() from tools/perf")
    Fixes: 246eba8e ("perf tools: Add support for PERF_RECORD_TEXT_POKE")
    Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
    Acked-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: stable@vger.kernel.org # 5.5+
    Link: https://lore.kernel.org/r/20220413114232.26914-1-adrian.hunter@intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    a668cc07
evlist.c 15.7 KB