• Nícolas F. R. A. Prado's avatar
    ASoC: mediatek: mt8192-mt6359: Go back to old headphone pin name · e352f31a
    Nícolas F. R. A. Prado authored
    This reverts commit cbbc0ec6 ("ASoC: mediatek: mt8192-mt6359:
    Remove " Jack" from Headphone pin name"). That commit removed the "
    Jack" suffix with the reasoning that it is automatically added to the
    name of the kcontrol created, which is true, but this name is also used
    to look for the DAPM widget that will be toggled when the jack status is
    updated. Since the widget is still called "Headphone Jack" the jack
    can't link to the widget and the following error is shown:
    
    mt8192_mt6359 sound: ASoC: DAPM unknown pin Headphone
    
    It is not possible to also rename the headphone DAPM widget because its
    name is used by a switch kcontrol, "Headphone Jack Switch", both to link
    to the headphone widget and to assemble its name. This switch's name is
    referenced in the upstream UCM file, so renaming it would break
    userspace. Since the original commit didn't bring any benefit, besides
    sparing a few CPU cycles, simply revert it.
    Signed-off-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
    Link: https://lore.kernel.org/r/20230608221050.217968-1-nfraprado@collabora.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    e352f31a
mt8192-mt6359-rt1015-rt5682.c 34.6 KB