• simran singhal's avatar
    iio: dac: ad5504: constify attribute_group structures · e36020fd
    simran singhal authored
    Check for attribute_group structures that are only stored in the
    event_attrs filed of iio_info structure. As the event_attrs field of
    iio_info structures is constant, so these attribute_group structures can
    also be declared constant. Done using coccinelle:
    
    @r1 disable optional_qualifier @
    identifier i;
    position p;
    @@
    static struct attribute_group i@p = {...};
    
    @ok1@
    identifier r1.i;
    position p;
    struct iio_info x;
    @@
    x.event_attrs=&i@p;
    
    @bad@
    position p!={r1.p,ok1.p};
    identifier r1.i;
    @@
    i@p
    
    @depends on !bad disable optional_qualifier@
    identifier r1.i;
    @@
    static
    +const
    struct attribute_group i={...};
    
    @depends on !bad disable optional_qualifier@
    identifier r1.i;
    @@
    +const
    struct attribute_group i;
    
    File size before:
       text    data     bss     dec     hex filename
       3046     360       0    3406     d4e drivers/iio/dac/ad5504.o
    
    File size after:
       text	   data	    bss	    dec	    hex	filename
       3110	    296	      0	   3406	    d4e	drivers/iio/dac/ad5504.o
    Signed-off-by: default avatarsimran singhal <singhalsimran0@gmail.com>
    Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
    e36020fd
ad5504.c 8.54 KB