• Pavel Skripkin's avatar
    net: ethernet: aeroflex: fix UAF in greth_of_remove · e3a5de6d
    Pavel Skripkin authored
    static int greth_of_remove(struct platform_device *of_dev)
    {
    ...
    	struct greth_private *greth = netdev_priv(ndev);
    ...
    	unregister_netdev(ndev);
    	free_netdev(ndev);
    
    	of_iounmap(&of_dev->resource[0], greth->regs, resource_size(&of_dev->resource[0]));
    ...
    }
    
    greth is netdev private data, but it is used
    after free_netdev(). It can cause use-after-free when accessing greth
    pointer. So, fix it by moving free_netdev() after of_iounmap()
    call.
    
    Fixes: d4c41139 ("net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver")
    Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    e3a5de6d
greth.c 38.5 KB