• Thierry Reding's avatar
    ARM: tegra: Restore DT ABI on Tegra124 Chromebooks · e5257888
    Thierry Reding authored
    [ Upstream commit 94d9b933 ]
    
    Commit 48299769 ("ARM: tegra: Fix unit_address_vs_reg DTC warnings
    for /memory") inadventently broke device tree ABI by adding a unit-
    address to the "/memory" node because the device tree compiler flagged
    the missing unit-address as a warning.
    
    Tegra124 Chromebooks (a.k.a. Nyan) use a bootloader that relies on the
    full name of the memory node in device tree being exactly "/memory". It
    can be argued whether this was a good decision or not, and some other
    bootloaders (such as U-Boot) do accept a unit-address in the name of the
    node, but the device tree is an ABI and we can't break existing setups
    just because the device tree compiler considers it bad practice to omit
    the unit-address nowadays.
    
    This partially reverts the offending commit and restores device tree ABI
    compatibility.
    
    Fixes: 48299769 ("ARM: tegra: Fix unit_address_vs_reg DTC warnings for /memory")
    Reported-by: default avatarTristan Bastian <tristan-c.bastian@gmx.de>
    Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
    Tested-by: default avatarTristan Bastian <tristan-c.bastian@gmx.de>
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
    e5257888
tegra124-nyan.dtsi 17.9 KB