• Kai Huang's avatar
    KVM: x86/mmu: Add shadow_me_value and repurpose shadow_me_mask · e54f1ff2
    Kai Huang authored
    Intel Multi-Key Total Memory Encryption (MKTME) repurposes couple of
    high bits of physical address bits as 'KeyID' bits.  Intel Trust Domain
    Extentions (TDX) further steals part of MKTME KeyID bits as TDX private
    KeyID bits.  TDX private KeyID bits cannot be set in any mapping in the
    host kernel since they can only be accessed by software running inside a
    new CPU isolated mode.  And unlike to AMD's SME, host kernel doesn't set
    any legacy MKTME KeyID bits to any mapping either.  Therefore, it's not
    legitimate for KVM to set any KeyID bits in SPTE which maps guest
    memory.
    
    KVM maintains shadow_zero_check bits to represent which bits must be
    zero for SPTE which maps guest memory.  MKTME KeyID bits should be set
    to shadow_zero_check.  Currently, shadow_me_mask is used by AMD to set
    the sme_me_mask to SPTE, and shadow_me_shadow is excluded from
    shadow_zero_check.  So initializing shadow_me_mask to represent all
    MKTME keyID bits doesn't work for VMX (as oppositely, they must be set
    to shadow_zero_check).
    
    Introduce a new 'shadow_me_value' to replace existing shadow_me_mask,
    and repurpose shadow_me_mask as 'all possible memory encryption bits'.
    The new schematic of them will be:
    
     - shadow_me_value: the memory encryption bit(s) that will be set to the
       SPTE (the original shadow_me_mask).
     - shadow_me_mask: all possible memory encryption bits (which is a super
       set of shadow_me_value).
     - For now, shadow_me_value is supposed to be set by SVM and VMX
       respectively, and it is a constant during KVM's life time.  This
       perhaps doesn't fit MKTME but for now host kernel doesn't support it
       (and perhaps will never do).
     - Bits in shadow_me_mask are set to shadow_zero_check, except the bits
       in shadow_me_value.
    
    Introduce a new helper kvm_mmu_set_me_spte_mask() to initialize them.
    Replace shadow_me_mask with shadow_me_value in almost all code paths,
    except the one in PT64_PERM_MASK, which is used by need_remote_flush()
    to determine whether remote TLB flush is needed.  This should still use
    shadow_me_mask as any encryption bit change should need a TLB flush.
    And for AMD, move initializing shadow_me_value/shadow_me_mask from
    kvm_mmu_reset_all_pte_masks() to svm_hardware_setup().
    Signed-off-by: default avatarKai Huang <kai.huang@intel.com>
    Message-Id: <f90964b93a3398b1cf1c56f510f3281e0709e2ab.1650363789.git.kai.huang@intel.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    e54f1ff2
spte.c 13.9 KB