• Arend van Spriel's avatar
    wifi: brcmfmac: avoid handling disabled channels for survey dump · e5d1ab1a
    Arend van Spriel authored
    An issue was reported in which periodically error messages are
    printed in the kernel log:
    
    [   26.303445] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac43455-sdio for chip BCM4345/6
    [   26.303554] brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin failed with error -2
    [   26.516752] brcmfmac_wcc: brcmf_wcc_attach: executing
    [   26.528264] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4345/6 wl0: Jan  4 2021 19:56:29 version 7.45.229 (617f1f5 CY) FWID 01-2dbd9d2e
    [   27.076829] Bluetooth: hci0: BCM: features 0x2f
    [   27.078592] Bluetooth: hci0: BCM43455 37.4MHz Raspberry Pi 3+
    [   27.078601] Bluetooth: hci0: BCM4345C0 (003.001.025) build 0342
    [   30.142104] Adding 102396k swap on /var/swap.  Priority:-2 extents:1 across:102396k SS
    [   30.590017] Bluetooth: MGMT ver 1.22
    [  104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail, reason -52
    [  104.897992] brcmfmac: cfg80211_set_channel: set chanspec 0xd022 fail, reason -52
    [  105.007672] brcmfmac: cfg80211_set_channel: set chanspec 0xd026 fail, reason -52
    [  105.117654] brcmfmac: cfg80211_set_channel: set chanspec 0xd02a fail, reason -52
    [  105.227636] brcmfmac: cfg80211_set_channel: set chanspec 0xd02e fail, reason -52
    [  106.987552] brcmfmac: cfg80211_set_channel: set chanspec 0xd090 fail, reason -52
    [  106.987911] brcmfmac: cfg80211_set_channel: set chanspec 0xd095 fail, reason -52
    [  106.988233] brcmfmac: cfg80211_set_channel: set chanspec 0xd099 fail, reason -52
    [  106.988565] brcmfmac: cfg80211_set_channel: set chanspec 0xd09d fail, reason -52
    [  106.988909] brcmfmac: cfg80211_set_channel: set chanspec 0xd0a1 fail, reason -52
    
    This happens in brcmf_cfg80211_dump_survey() because we try a disabled
    channel. When channel is marked as disabled we do not need to fill any
    other info so bail out.
    
    Fixes: 6c04deae ("brcmfmac: Add dump_survey cfg80211 ops for HostApd AutoChannelSelection")
    Reported-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
    Signed-off-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
    Tested-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
    Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/20230103124117.271988-2-arend.vanspriel@broadcom.com
    e5d1ab1a
cfg80211.c 225 KB