• Zhang Lei's avatar
    KVM: arm64/sve: Fix vq_present() macro to yield a bool · e644fa18
    Zhang Lei authored
    The original implementation of vq_present() relied on aggressive
    inlining in order for the compiler to know that the code is
    correct, due to some const-casting issues.  This was causing sparse
    and clang to complain, while GCC compiled cleanly.
    
    Commit 0c529ff7 addressed this problem, but since vq_present()
    is no longer a function, there is now no implicit casting of the
    returned value to the return type (bool).
    
    In set_sve_vls(), this uncast bit value is compared against a bool,
    and so may spuriously compare as unequal when both are nonzero.  As
    a result, KVM may reject valid SVE vector length configurations as
    invalid, and vice versa.
    
    Fix it by forcing the returned value to a bool.
    Signed-off-by: default avatarZhang Lei <zhang.lei@jp.fujitsu.com>
    Fixes: 0c529ff7 ("KVM: arm64: Implement vq_present() as a macro")
    Signed-off-by: Dave Martin <Dave.Martin@arm.com> [commit message rewrite]
    Cc: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    e644fa18
guest.c 21.5 KB