• Qu Wenruo's avatar
    btrfs: refactor how we finish ordered extent io for endio functions · e65f152e
    Qu Wenruo authored
    Btrfs has two endio functions to mark certain io range finished for
    ordered extents:
    
    - __endio_write_update_ordered()
      This is for direct IO
    
    - btrfs_writepage_endio_finish_ordered()
      This for buffered IO.
    
    However they go different routines to handle ordered extent io:
    
    - Whether to iterate through all ordered extents
      __endio_write_update_ordered() will but
      btrfs_writepage_endio_finish_ordered() will not.
    
      In fact, iterating through all ordered extents will benefit later
      subpage support, while for current PAGE_SIZE == sectorsize requirement
      this behavior makes no difference.
    
    - Whether to update page Private2 flag
      __endio_write_update_ordered() will not update page Private2 flag as
      for iomap direct IO, the page can not be even mapped.
      While btrfs_writepage_endio_finish_ordered() will clear Private2 to
      prevent double accounting against btrfs_invalidatepage().
    
    Those differences are pretty subtle, and the ordered extent iterations
    code in callers makes code much harder to read.
    
    So this patch will introduce a new function,
    btrfs_mark_ordered_io_finished(), to do the heavy lifting:
    
    - Iterate through all ordered extents in the range
    - Do the ordered extent accounting
    - Queue the work for finished ordered extent
    
    This function has two new feature:
    
    - Proper underflow detection and recovery
      The old underflow detection will only detect the problem, then
      continue.
      No proper info like root/inode/ordered extent info, nor noisy enough
      to be caught by fstests.
    
      Furthermore when underflow happens, the ordered extent will never
      finish.
    
      New error detection will reset the bytes_left to 0, do proper
      kernel warning, and output extra info including root, ino, ordered
      extent range, the underflow value.
    
    - Prevent double accounting based on Private2 flag
      Now if we find a range without Private2 flag, we will skip to next
      range.
      As that means someone else has already finished the accounting of
      ordered extent.
    
      This makes no difference for current code, but will be a critical part
      for incoming subpage support, as we can call
      btrfs_mark_ordered_io_finished() for multiple sectors if they are
      beyond inode size.
      Thus such double accounting prevention is a key feature for subpage.
    
    Now both endio functions only need to call that new function.
    
    And since the only caller of btrfs_dec_test_first_ordered_pending() is
    removed, also remove btrfs_dec_test_first_ordered_pending() completely.
    Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    e65f152e
ordered-data.h 6.3 KB