• Krishna chaitanya chundru's avatar
    perf/dwc_pcie: Fix registration issue in multi PCIe controller instances · e6693885
    Krishna chaitanya chundru authored
    When there are multiple of instances of PCIe controllers, registration
    to perf driver fails with this error.
    sysfs: cannot create duplicate filename '/devices/platform/dwc_pcie_pmu.0'
    CPU: 0 PID: 166 Comm: modprobe Not tainted 6.10.0-rc2-next-20240607-dirty
    Hardware name: Qualcomm SA8775P Ride (DT)
    Call trace:
     dump_backtrace.part.8+0x98/0xf0
     show_stack+0x14/0x1c
     dump_stack_lvl+0x74/0x88
     dump_stack+0x14/0x1c
     sysfs_warn_dup+0x60/0x78
     sysfs_create_dir_ns+0xe8/0x100
     kobject_add_internal+0x94/0x224
     kobject_add+0xa8/0x118
     device_add+0x298/0x7b4
     platform_device_add+0x1a0/0x228
     platform_device_register_full+0x11c/0x148
     dwc_pcie_register_dev+0x74/0xf0 [dwc_pcie_pmu]
     dwc_pcie_pmu_init+0x7c/0x1000 [dwc_pcie_pmu]
     do_one_initcall+0x58/0x1c0
     do_init_module+0x58/0x208
     load_module+0x1804/0x188c
     __do_sys_init_module+0x18c/0x1f0
     __arm64_sys_init_module+0x14/0x1c
     invoke_syscall+0x40/0xf8
     el0_svc_common.constprop.1+0x70/0xf4
     do_el0_svc+0x18/0x20
     el0_svc+0x28/0xb0
     el0t_64_sync_handler+0x9c/0xc0
     el0t_64_sync+0x160/0x164
    kobject: kobject_add_internal failed for dwc_pcie_pmu.0 with -EEXIST,
    don't try to register things with the same name in the same directory.
    
    This is because of having same bdf value for devices under two different
    controllers.
    
    Update the logic to use sbdf which is a unique number in case of
    multi instance also.
    
    Fixes: af9597ad ("drivers/perf: add DesignWare PCIe PMU driver")
    Signed-off-by: default avatarKrishna chaitanya chundru <quic_krichai@quicinc.com>
    Reviewed-by: default avatarYicong Yang <yangyicong@hisilicon.com>
    Link: https://lore.kernel.org/r/20240816-dwc_pmu_fix-v2-1-198b8ab1077c@quicinc.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
    e6693885
dwc_pcie_pmu.c 22.1 KB