• Kuniyuki Iwashima's avatar
    fs/lock: Rearrange ops in flock syscall. · db4abb4a
    Kuniyuki Iwashima authored
    The previous patch added flock_translate_cmd() in flock syscall.
    The test and the other one for LOCK_MAND do not depend on struct
    fd and are cheaper, so we can put them at the top and defer
    fdget() after that.
    
    Also, we can remove the unlock variable and use type instead.
    While at it, we fix this checkpatch error.
    
      CHECK: spaces preferred around that '|' (ctx:VxV)
      #45: FILE: fs/locks.c:2099:
      +	if (type != F_UNLCK && !(f.file->f_mode & (FMODE_READ|FMODE_WRITE)))
       	                                                     ^
    
    Finally, we can move the can_sleep part just before we use it.
    Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
    Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
    db4abb4a
locks.c 75.1 KB