• Sebastian Andrzej Siewior's avatar
    net: rtlwifi: Remove in_interrupt() from debug macro · e741751b
    Sebastian Andrzej Siewior authored
    The usage of in_interrupt() in drivers in is phased out.
    
    rtl_dbg() a printk based debug aid is using in_interrupt() in the
    underlying C function _rtl_dbg_out() which is almost identical to
    _rtl_dbg_print(). The only difference is the printout of in_interrupt().
    
    The decoding of in_interrupt() as hexvalue is non-trivial and aside of
    being phased out for driver usage the return value is just by chance the
    masked preempt count value and not a boolean.
    
    These home brewn printk debug aids are tedious to work with and provide
    only minimal context.  They should be replaced by trace_printk() or a debug
    tracepoint which automatically records all context information.
    
    To make progress on the in_interrupt() cleanup, make rtl_dbg() use
    _rtl_dbg_print() and remove _rtl_dbg_out().
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Acked-by: default avatarKalle Valo <kvalo@codeaurora.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    e741751b
debug.c 12.8 KB