• Matthew Auld's avatar
    drm/i915/ttm: fix CCS handling · e79a7417
    Matthew Auld authored
    Crucible + recent Mesa seems to sometimes hit:
    
    GEM_BUG_ON(num_ccs_blks > NUM_CCS_BLKS_PER_XFER)
    
    And it looks like we can also trigger this with gem_lmem_swapping, if we
    modify the test to use slightly larger object sizes.
    
    Looking closer it looks like we have the following issues in
    migrate_copy():
    
      - We are using plain integer in various places, which we can easily
        overflow with a large object.
    
      - We pass the entire object size (when the src is lmem) into
        emit_pte() and then try to copy it, which doesn't work, since we
        only have a few fixed sized windows in which to map the pages and
        perform the copy. With an object > 8M we therefore aren't properly
        copying the pages. And then with an object > 64M we trigger the
        GEM_BUG_ON(num_ccs_blks > NUM_CCS_BLKS_PER_XFER).
    
    So it looks like our copy handling for any object > 8M (which is our
    CHUNK_SZ) is currently broken on DG2.
    
    Fixes: da0595ae ("drm/i915/migrate: Evict and restore the flatccs capable lmem obj")
    Testcase: igt@gem_lmem_swapping
    Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
    Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
    Cc: Ramalingam C <ramalingam.c@intel.com>
    Reviewed-by: Ramalingam C<ramalingam.c@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220805132240.442747-2-matthew.auld@intel.com
    (cherry picked from commit 8676145e)
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    e79a7417
intel_migrate.c 28.4 KB