• Trond Myklebust's avatar
    NFS: Fix another OPEN_DOWNGRADE bug · e547f262
    Trond Myklebust authored
    Olga Kornievskaia reports that the following test fails to trigger
    an OPEN_DOWNGRADE on the wire, and only triggers the final CLOSE.
    
    	fd0 = open(foo, RDRW)   -- should be open on the wire for "both"
    	fd1 = open(foo, RDONLY)  -- should be open on the wire for "read"
    	close(fd0) -- should trigger an open_downgrade
    	read(fd1)
    	close(fd1)
    
    The issue is that we're missing a check for whether or not the current
    state transitioned from an O_RDWR state as opposed to having transitioned
    from a combination of O_RDONLY and O_WRONLY.
    Reported-by: default avatarOlga Kornievskaia <aglo@umich.edu>
    Fixes: cd9288ff ("NFSv4: Fix another bug in the close/open_downgrade code")
    Cc: stable@vger.kernel.org # 2.6.33+
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
    Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
    e547f262
nfs4proc.c 240 KB