• Si-Wei Liu's avatar
    vdpa: validate provisioned device features against specified attribute · e7d09cd1
    Si-Wei Liu authored
    With device feature provisioning, there's a chance for misconfiguration
    that the vdpa feature attribute supplied in 'vdpa dev add' command doesn't
    get selected on the device_features to be provisioned. For instance, when
    a @mac attribute is specified, the corresponding feature bit _F_MAC in
    device_features should be set for consistency. If there's conflict on
    provisioned features against the attribute, it should be treated as an
    error to fail the ambiguous command. Noted the opposite is not
    necessarily true, for e.g. it's okay to have _F_MAC set in device_features
    without providing a corresponding @mac attribute, in which case the vdpa
    vendor driver could load certain default value for attribute that is not
    explicitly specified.
    
    Generalize this check in vdpa core so that there's no duplicate code in
    each vendor driver.
    Signed-off-by: default avatarSi-Wei Liu <si-wei.liu@oracle.com>
    Reviewed-by: default avatarEli Cohen <elic@nvidia.com>
    Message-Id: <1675725124-7375-4-git-send-email-si-wei.liu@oracle.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    e7d09cd1
vdpa.c 31.9 KB