• Arkadiusz Kubalewski's avatar
    ice: fix pin phase adjust updates on PF reset · ee89921d
    Arkadiusz Kubalewski authored
    Do not allow to set phase adjust value for a pin if PF reset is in
    progress, this would cause confusing netlink extack errors as the firmware
    cannot process the request properly during the reset time.
    
    Return (-EBUSY) and report extack error for the user who tries configure
    pin phase adjust during the reset time.
    
    Test by looping execution of below steps until netlink error appears:
    - perform PF reset
    $ echo 1 > /sys/class/net/<ice PF>/device/reset
    - change pin phase adjust value:
    $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml \
    	--do pin-set --json '{"id":0, "phase-adjust":1000}'
    
    Fixes: 90e1c907 ("ice: dpll: implement phase related callbacks")
    Reviewed-by: default avatarIgor Bagnucki <igor.bagnucki@intel.com>
    Signed-off-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
    Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
    Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
    ee89921d
ice_dpll.c 59.2 KB