Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
  • linux
  • kernel
  • bpf
  • devmap.c
Find file BlameHistoryPermalink
  • Hangbin Liu's avatar
    bpf, devmap: Remove drops variable from bq_xmit_all() · e8e0f0f4
    Hangbin Liu authored May 27, 2021
    As Colin pointed out, the first drops assignment after declaration will
    be overwritten by the second drops assignment before using, which makes
    it useless.
    
    Since the drops variable will be used only once. Just remove it and
    use "cnt - sent" in trace_xdp_devmap_xmit().
    
    Fixes: cb261b59
    
     ("bpf: Run devmap xdp_prog on flush instead of bulk enqueue")
    Reported-by: default avatarColin Ian King <colin.king@canonical.com>
    Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
    Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    Acked-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
    Link: https://lore.kernel.org/bpf/20210528024356.24333-1-liuhangbin@gmail.com
    e8e0f0f4
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7