• Dan Carpenter's avatar
    cifs: fix a sign extension bug · e946d3c8
    Dan Carpenter authored
    The problem is the mismatched types between "ctx->total_len" which is
    an unsigned int, "rc" which is an int, and "ctx->rc" which is a
    ssize_t.  The code does:
    
    	ctx->rc = (rc == 0) ? ctx->total_len : rc;
    
    We want "ctx->rc" to store the negative "rc" error code.  But what
    happens is that "rc" is type promoted to a high unsigned int and
    'ctx->rc" will store the high positive value instead of a negative
    value.
    
    The fix is to change "rc" from an int to a ssize_t.
    
    Fixes: c610c4b6 ("CIFS: Add asynchronous write support through kernel AIO")
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
    e946d3c8
file.c 127 KB