• Michael Ellerman's avatar
    net: apple: bmac: Fix build since dev_addr constification · ea938248
    Michael Ellerman authored
    Since commit adeef3e3 ("net: constify netdev->dev_addr") the bmac
    driver no longer builds with the following errors (pmac32_defconfig):
    
      linux/drivers/net/ethernet/apple/bmac.c: In function ‘bmac_probe’:
      linux/drivers/net/ethernet/apple/bmac.c:1287:20: error: assignment of read-only location ‘*(dev->dev_addr + (sizetype)j)’
       1287 |   dev->dev_addr[j] = rev ? bitrev8(addr[j]): addr[j];
            |                    ^
    
    Fix it by making the modifications to a local macaddr variable and then
    passing that to eth_hw_addr_set().
    
    We don't use the existing addr variable because the bitrev8() would
    mutate it, but it is already used unreversed later in the function.
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ea938248
bmac.c 41 KB