• Gustavo A. R. Silva's avatar
    liquidio: lio_main: remove unnecessary static in setup_io_queues() · eb2b9874
    Gustavo A. R. Silva authored
    Remove unnecessary static on local variables cpu_id_modulus and cpu_id.
    Such variables are initialized before being used, on every execution
    path throughout the function. The static has no benefit and, removing
    it reduces the object file size.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    
    In the following log you can see a significant difference in the object
    file size. Also, there is a significant difference in the bss segment.
    This log is the output of the size command, before and after the code
    change:
    
    before:
       text    data     bss     dec     hex filename
      78689   15272   27808  121769   1dba9 drivers/net/ethernet/cavium/liquidio/lio_main.o
    
    after:
       text    data     bss     dec     hex filename
      78667   15128   27680  121475   1da83 drivers/net/ethernet/cavium/liquidio/lio_main.o
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Acked-by: default avatarFelix Manlunas <felix.manlunas@cavium.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    eb2b9874
lio_main.c 123 KB