• Linus Torvalds's avatar
    Revert "jbd2: speedup jbd2_journal_dirty_metadata()" · ebeaa8dd
    Linus Torvalds authored
    This reverts commit 2143c196.
    
    This commit seems to be the cause of the following jbd2 assertion
    failure:
    
       ------------[ cut here ]------------
       kernel BUG at fs/jbd2/transaction.c:1325!
       invalid opcode: 0000 [#1] SMP
       Modules linked in: bnep bluetooth fuse ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 ...
       CPU: 7 PID: 5509 Comm: gcc Not tainted 4.1.0-10944-g2a298679 #1
       Hardware name:                  /DH87RL, BIOS RLH8710H.86A.0327.2014.0924.1645 09/24/2014
       task: ffff8803bf866040 ti: ffff880308528000 task.ti: ffff880308528000
       RIP: jbd2_journal_dirty_metadata+0x237/0x290
       Call Trace:
         __ext4_handle_dirty_metadata+0x43/0x1f0
         ext4_handle_dirty_dirent_node+0xde/0x160
         ? jbd2_journal_get_write_access+0x36/0x50
         ext4_delete_entry+0x112/0x160
         ? __ext4_journal_start_sb+0x52/0xb0
         ext4_unlink+0xfa/0x260
         vfs_unlink+0xec/0x190
         do_unlinkat+0x24a/0x270
         SyS_unlink+0x11/0x20
         entry_SYSCALL_64_fastpath+0x12/0x6a
       ---[ end trace ae033ebde8d080b4 ]---
    
    which is not easily reproducible (I've seen it just once, and then Ted
    was able to reproduce it once).  Revert it while Ted and Jan try to
    figure out what is wrong.
    
    Cc: Jan Kara <jack@suse.cz>
    Acked-by: default avatarTheodore Ts'o <tytso@mit.edu>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ebeaa8dd
transaction.c 77 KB