• Tahsin Erdogan's avatar
    ext4: inplace xattr block update fails to deduplicate blocks · ec000220
    Tahsin Erdogan authored
    When an xattr block has a single reference, block is updated inplace
    and it is reinserted to the cache. Later, a cache lookup is performed
    to see whether an existing block has the same contents. This cache
    lookup will most of the time return the just inserted entry so
    deduplication is not achieved.
    
    Running the following test script will produce two xattr blocks which
    can be observed in "File ACL: " line of debugfs output:
    
      mke2fs -b 1024 -I 128 -F -O extent /dev/sdb 1G
      mount /dev/sdb /mnt/sdb
    
      touch /mnt/sdb/{x,y}
    
      setfattr -n user.1 -v aaa /mnt/sdb/x
      setfattr -n user.2 -v bbb /mnt/sdb/x
    
      setfattr -n user.1 -v aaa /mnt/sdb/y
      setfattr -n user.2 -v bbb /mnt/sdb/y
    
      debugfs -R 'stat x' /dev/sdb | cat
      debugfs -R 'stat y' /dev/sdb | cat
    
    This patch defers the reinsertion to the cache so that we can locate
    other blocks with the same contents.
    Signed-off-by: default avatarTahsin Erdogan <tahsin@google.com>
    Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
    Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
    ec000220
xattr.c 79.2 KB