• David Arcari's avatar
    net: ethernet: aquantia: call set_irq_affinity_hint before free_irq · ecd05225
    David Arcari authored
    When a network interface controlled by the aquantia ethernet driver is brought
    down a warning is output in dmesg (see below).
    
    The problem is that aq_pci_func_free_irqs() is calling free_irq() before it is
    calling irq_set_affinity_hint().
    
    WARNING: CPU: 4 PID: 10068 at kernel/irq/manage.c:1503 __free_irq+0x24d/0x2b0
    <snip>
    Call Trace:
     dump_stack+0x63/0x87
     __warn+0xd1/0xf0
     warn_slowpath_null+0x1d/0x20
     __free_irq+0x24d/0x2b0
     free_irq+0x39/0x90
     aq_pci_func_free_irqs+0x52/0xa0 [atlantic]
     aq_nic_stop+0xca/0xd0 [atlantic]
     aq_ndev_close+0x1d/0x40 [atlantic]
     __dev_close_many+0x99/0x100
     __dev_close+0x67/0xb0
    <snip>
    
    Fixes: 36a4a50f ("net: ethernet: aquantia: switch to pci_alloc_irq_vectors")
    
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Pavel Belous <pavel.belous@aquantia.com>
    Signed-off-by: default avatarDavid Arcari <darcari@redhat.com>
    Tested-by: default avatarPavel Belous <pavel.belous@aquantia.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ecd05225
aq_pci_func.c 5.88 KB