• Justin Tee's avatar
    scsi: lpfc: Remove duplicate ndlp kref decrement in lpfc_cleanup_rpis() · ecdf4ddf
    Justin Tee authored
    With faulty cables in PT2PT topology, an unintentional ndlp double kref
    decrement can occur.
    
    If a FLOGI request is outstanding before the link goes down, the missing
    FLOGI_ACC causes an F_Port ndlp to remain in the UNUSED state.  During link
    down, lpfc_cleanup_rpis() is called and decrements an ndlp kref.
    Additionally, when the driver later decides to abort the FLOGI, the FLOGI
    completion handler decrements the ndlp kref a second time.
    
    Remove duplicate clean up logic in lpfc_cleanup_rpis() because the updated
    FLOGI completion handler already handles the ndlp kref decrement.
    Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    ecdf4ddf
lpfc_hbadisc.c 211 KB