• Oliver Upton's avatar
    KVM: arm64: Don't miss pending interrupts for suspended vCPU · a867e9d0
    Oliver Upton authored
    In order to properly emulate the WFI instruction, KVM reads back
    ICH_VMCR_EL2 and enables doorbells for GICv4. These preparations are
    necessary in order to recognize pending interrupts in
    kvm_arch_vcpu_runnable() and return to the guest. Until recently, this
    work was done by kvm_arch_vcpu_{blocking,unblocking}(). Since commit
    6109c5a6 ("KVM: arm64: Move vGIC v4 handling for WFI out arch
    callback hook"), these callbacks were gutted and superseded by
    kvm_vcpu_wfi().
    
    It is important to note that KVM implements PSCI CPU_SUSPEND calls as
    a WFI within the guest. However, the implementation calls directly into
    kvm_vcpu_halt(), which skips the needed work done in kvm_vcpu_wfi()
    to detect pending interrupts. Fix the issue by calling the WFI helper.
    
    Fixes: 6109c5a6 ("KVM: arm64: Move vGIC v4 handling for WFI out arch callback hook")
    Signed-off-by: default avatarOliver Upton <oupton@google.com>
    Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20220217101242.3013716-1-oupton@google.com
    a867e9d0
psci.c 14 KB