• Stephen Kitt's avatar
    fbdev: atmel_lcdfb: Rework backlight status updates · ee4202db
    Stephen Kitt authored
    Instead of checking the state of various backlight_properties fields
    against the memorised state in atmel_lcdfb_info.bl_power,
    atmel_bl_update_status() should retrieve the desired state using
    backlight_get_brightness (which takes into account the power state,
    blanking etc.). This means the explicit checks using props.fb_blank
    and props.power can be dropped.
    
    The backlight framework ensures that backlight is never negative, so
    the test before reading the brightness from the hardware always ends
    up false and the whole block can be removed. The framework retrieves
    the brightness from the hardware through atmel_bl_get_brightness()
    when necessary.
    
    As a result, bl_power in struct atmel_lcdfb_info is no longer
    necessary, so remove that while we're at it. Since we only ever care
    about reading the current state in backlight_properties, drop the
    updates at the end of the function.
    Signed-off-by: default avatarStephen Kitt <steve@sk2.org>
    Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    ee4202db
atmel_lcdfb.c 35.8 KB