• Tvrtko Ursulin's avatar
    drm/i915: Fix struct mutex vs. RPS lock inversion · ee504898
    Tvrtko Ursulin authored
    RPS lock must be taken before the struct_mutex to avoid
    locking inversion. So stop grabbing it for the whole
    powersave initialization and instead only take it during
    the sections which need it.
    
    Also, struct_mutex is not needed any more since dedicated
    RPS lock was added in:
    
       commit 4fc688ce
       Author: Jesse Barnes <jbarnes@virtuousgeek.org>
       Date:   Fri Nov 2 11:14:01 2012 -0700
    
           drm/i915: protect RPS/RC6 related accesses (including PCU) with a new mutex
    
    Based on prototype patch by Chris Wilson and a subsequent
    mailing list discussion involving Ville, Imre, Chris and
    Daniel.
    
    v2: More details in the commit.
    
    v3: Use drm_gem_object_unreference_unlocked. (Chris Wilson)
    Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Cc: Imre Deak <imre.deak@intel.com>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    ee504898
intel_display.c 452 KB