• Ondrej Mosnacek's avatar
    selinuxfs: unify policy load error reporting · ee5de60a
    Ondrej Mosnacek authored
    Let's drop the pr_err()s from sel_make_policy_nodes() and just add one
    pr_warn_ratelimited() call to the sel_make_policy_nodes() error path in
    sel_write_load().
    
    Changing from error to warning makes sense, since after 02a52c5c
    ("selinux: move policy commit after updating selinuxfs"), this error
    path no longer leads to a broken selinuxfs tree (it's just kept in the
    original state and policy load is aborted).
    
    I also added _ratelimited to be consistent with the other prtin in the
    same function (it's probably not necessary, but can't really hurt...
    there are likely more important error messages to be printed when
    filesystem entry creation starts erroring out).
    Suggested-by: default avatarPaul Moore <paul@paul-moore.com>
    Signed-off-by: default avatarOndrej Mosnacek <omosnace@redhat.com>
    Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
    ee5de60a
selinuxfs.c 53.4 KB