• Andrew Lunn's avatar
    net: mdio: xgmac_mdio: Separate C22 and C45 transactions · c0fc8e6d
    Andrew Lunn authored
    The xgmac MDIO bus driver can perform both C22 and C45 transfers.
    Create separate functions for each and register the C45 versions using
    the new API calls where appropriate.
    
    While at it, remove the misleading comment. According to Vladimir
    Oltean:
     - miimcom is a register accessed by fsl_pq_mdio.c, not by xgmac_mdio.c
     - "device dev" doesn't really refer to anything (maybe "dev_addr").
     - I don't understand what is meant by the comment "All PHY
       configuration has to be done through the TSEC1 MIIM regs". Or rather
       said, I think I understand, but it is irrelevant to the driver for 2
       reasons:
        * TSEC devices use the fsl_pq_mdio.c driver, not this one
        * It doesn't matter to this driver whose TSEC registers are used for
          MDIO access. The driver just works with the registers it's given,
          which is a concern for the device tree.
     - barring the above, the rest just describes the MDIO bus API, which is
       superfluous
    Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
    Signed-off-by: default avatarMichael Walle <michael@walle.cc>
    Tested-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    c0fc8e6d
xgmac_mdio.c 12.3 KB