• Adam Wujek's avatar
    hwmon: (pmbus) disable PEC if not enabled · 75d2b2b0
    Adam Wujek authored
    Explicitly disable PEC when the client does not support it.
    The problematic scenario is the following. A device with enabled PEC
    support is up and running and a kernel driver is loaded.
    Then the driver is unloaded (or device unbound), the HW device
    is reconfigured externally (e.g. by i2cset) to advertise itself as not
    supporting PEC. Without a new code, at the second load of the driver
    (or bind) the "flags" variable is not updated to avoid PEC usage. As a
    consequence the further communication with the device is done with
    the PEC enabled, which is wrong and may fail.
    
    The implementation first disable the I2C_CLIENT_PEC flag, then the old
    code enable it if needed.
    
    Fixes: 4e5418f7 ("hwmon: (pmbus_core) Check adapter PEC support")
    Signed-off-by: default avatarAdam Wujek <dev_public@wujek.eu>
    Link: https://lore.kernel.org/r/20220420145059.431061-1-dev_public@wujek.euSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    75d2b2b0
pmbus_core.c 71.3 KB