• Aaron Tomlin's avatar
    module: Make internal.h and decompress.c more compliant · 5aff4dfd
    Aaron Tomlin authored
    This patch will address the following warning and style violations
    generated by ./scripts/checkpatch.pl in strict mode:
    
      WARNING: Use #include <linux/module.h> instead of <asm/module.h>
      #10: FILE: kernel/module/internal.h:10:
      +#include <asm/module.h>
    
      CHECK: spaces preferred around that '-' (ctx:VxV)
      #18: FILE: kernel/module/internal.h:18:
      +#define INIT_OFFSET_MASK (1UL << (BITS_PER_LONG-1))
    
      CHECK: Please use a blank line after function/struct/union/enum declarations
      #69: FILE: kernel/module/internal.h:69:
      +}
      +static inline void module_decompress_cleanup(struct load_info *info)
    						   ^
      CHECK: extern prototypes should be avoided in .h files
      #84: FILE: kernel/module/internal.h:84:
      +extern int mod_verify_sig(const void *mod, struct load_info *info);
    
      WARNING: Missing a blank line after declarations
      #116: FILE: kernel/module/decompress.c:116:
      +               struct page *page = module_get_next_page(info);
      +               if (!page) {
    
      WARNING: Missing a blank line after declarations
      #174: FILE: kernel/module/decompress.c:174:
      +               struct page *page = module_get_next_page(info);
      +               if (!page) {
    
      CHECK: Please use a blank line after function/struct/union/enum declarations
      #258: FILE: kernel/module/decompress.c:258:
      +}
      +static struct kobj_attribute module_compression_attr = __ATTR_RO(compression);
    
    Note: Fortunately, the multiple-include optimisation found in
    include/linux/module.h will prevent duplication/or inclusion more than
    once.
    
    Fixes: f314dfea ("modsign: log module name in the event of an error")
    Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
    Signed-off-by: default avatarAaron Tomlin <atomlin@redhat.com>
    Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
    5aff4dfd
decompress.c 5.67 KB