• Ard Biesheuvel's avatar
    arm64: efi: remove pointless dummy .reloc section · effc7b02
    Ard Biesheuvel authored
    The kernel's EFI PE/COFF header contains a dummy .reloc section, and
    an explanatory comment that claims that this is required for the EFI
    application loader to accept the Image as a relocatable image (i.e.,
    one that can be loaded at any offset and fixed up in place)
    
    This was inherited from the x86 implementation, which has elaborate host
    tooling to mangle the PE/COFF header post-link time, and which populates
    the .reloc section with a single dummy base relocation. On ARM, no such
    tooling exists, and the .reloc section remains empty, and is never even
    exposed via the BaseRelocationTable directory entry, which is where the
    PE/COFF loader looks for it.
    
    The PE/COFF spec is unclear about relocatable images that do not require
    any fixups, but the EDK2 implementation, which is the de facto reference
    for PE/COFF in the UEFI space, clearly does not care, and explicitly
    mentions (in a comment) that relocatable images with no base relocations
    are perfectly fine, as long as they don't have the RELOCS_STRIPPED
    attribute set (which is not the case for our PE/COFF image)
    
    So simply remove the .reloc section altogether.
    Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
    Acked-by: default avatarPeter Jones <pjones@redhat.com>
    Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    effc7b02
efi-header.S 4.2 KB