• Eric Dumazet's avatar
    ibmvnic: remove ndo_poll_controller · 0c3b9d1b
    Eric Dumazet authored
    As diagnosed by Song Liu, ndo_poll_controller() can
    be very dangerous on loaded hosts, since the cpu
    calling ndo_poll_controller() might steal all NAPI
    contexts (for all RX/TX queues of the NIC). This capture
    can last for unlimited amount of time, since one
    cpu is generally not able to drain all the queues under load.
    
    ibmvnic uses NAPI for TX completions, so we better let core
    networking stack call the napi->poll() to avoid the capture.
    
    ibmvnic_netpoll_controller() was completely wrong anyway,
    as it was scheduling NAPI to service RX queues (instead of TX),
    so I doubt netpoll ever worked on this driver.
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
    Cc: John Allen <jallen@linux.vnet.ibm.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    0c3b9d1b
ibmvnic.c 133 KB