• Jon Paul Maloy's avatar
    tipc: fix bug in multicast/broadcast message reassembly · 29322d0d
    Jon Paul Maloy authored
    Since commit 37e22164 ("tipc: rename and
    move message reassembly function") reassembly of long broadcast messages
    has been broken. This is because we test for a non-NULL return value
    of the *buf parameter as criteria for succesful reassembly. However, this
    parameter is left defined even after reception of the first fragment,
    when reassebly is still incomplete. This leads to a kernel crash as soon
    as a the first fragment of a long broadcast message is received.
    
    We fix this with this commit, by implementing a stricter behavior of the
    function and its return values.
    
    This commit should be applied to both net and net-next.
    Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Acked-by: default avatarYing Xue <ying.xue@windriver.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    29322d0d
msg.c 4.83 KB