• Andy Lutomirski's avatar
    x86/boot/32: Fix UP boot on Quark and possibly other platforms · d2b6dc61
    Andy Lutomirski authored
    This partially reverts commit:
    
      23b2a4dd ("x86/boot/32: Defer resyncing initial_page_table until per-cpu is set up")
    
    That commit had one definite bug and one potential bug.  The
    definite bug is that setup_per_cpu_areas() uses a differnet generic
    implementation on UP kernels, so initial_page_table never got
    resynced.  This was fine for access to percpu data (it's in the
    identity map on UP), but it breaks other users of
    initial_page_table.  The potential bug is that helpers like
    efi_init() would be called before the tables were synced.
    
    Avoid both problems by just syncing the page tables in setup_arch()
    *and* setup_per_cpu_areas().
    Reported-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
    Signed-off-by: default avatarAndy Lutomirski <luto@kernel.org>
    Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
    Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Juergen Gross <jgross@suse.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Matt Fleming <matt@codeblueprint.co.uk>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Garnier <thgarnie@google.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-efi@vger.kernel.org
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    d2b6dc61
setup.c 32.9 KB