• Gustavo A. R. Silva's avatar
    block: bio: Use struct_size() in kmalloc() · f1f8f292
    Gustavo A. R. Silva authored
    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:
    
    struct bio_map_data {
    	...
            struct iovec iov[];
    };
    
    instance = kmalloc(sizeof(sizeof(struct bio_map_data) + sizeof(struct iovec) *
                              count, GFP_KERNEL);
    
    Instead of leaving these open-coded and prone to type mistakes, we can
    now use the new struct_size() helper:
    
    instance = kmalloc(struct_size(instance, iov, count), GFP_KERNEL);
    
    This code was detected with the help of Coccinelle.
    Reviewed-by: default avatarKees Cook <keescook@chromium.org>
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    f1f8f292
bio.c 54.4 KB