• Gabriel Krisman Bertazi's avatar
    blk-cgroup: Pre-allocate tree node on blkg_conf_prep · f255c19b
    Gabriel Krisman Bertazi authored
    Similarly to commit 457e490f ("blkcg: allocate struct blkcg_gq
    outside request queue spinlock"), blkg_create can also trigger
    occasional -ENOMEM failures at the radix insertion because any
    allocation inside blkg_create has to be non-blocking, making it more
    likely to fail.  This causes trouble for userspace tools trying to
    configure io weights who need to deal with this condition.
    
    This patch reduces the occurrence of -ENOMEMs on this path by preloading
    the radix tree element on a GFP_KERNEL context, such that we guarantee
    the later non-blocking insertion won't fail.
    
    A similar solution exists in blkcg_init_queue for the same situation.
    Acked-by: default avatarTejun Heo <tj@kernel.org>
    Signed-off-by: default avatarGabriel Krisman Bertazi <krisman@collabora.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    f255c19b
blk-cgroup.c 49.9 KB