• Dave Chinner's avatar
    xfs: remove local fork format handling from xfs_bmapi_write() · f3508bcd
    Dave Chinner authored
    The conversion from local format to extent format requires
    interpretation of the data in the fork being converted, so it cannot
    be done in a generic way. It is up to the caller to convert the fork
    format to extent format before calling into xfs_bmapi_write() so
    format conversion can be done correctly.
    
    The code in xfs_bmapi_write() to convert the format is used
    implicitly by the attribute and directory code, but they
    specifically zero the fork size so that the conversion does not do
    any allocation or manipulation. Move this conversion into the
    shortform to leaf functions for the dir/attr code so the conversions
    are explicitly controlled by all callers.
    
    Now we can remove the conversion code in xfs_bmapi_write.
    Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
    Reviewed-by: default avatarMark Tinguely <tinguely@sgi.com>
    Signed-off-by: default avatarBen Myers <bpm@sgi.com>
    f3508bcd
xfs_dir2_block.c 37.4 KB