• Roger Quadros's avatar
    Bluetooth: Ensure that HCI sysfs add/del is preempt safe · f3784d83
    Roger Quadros authored
    Use a different work_struct variables for add_conn() and del_conn() and
    use single work queue instead of two for adding and deleting connections.
    
    It eliminates the following error on a preemptible kernel:
    
    [  204.358032] Unable to handle kernel NULL pointer dereference at virtual address 0000000c
    [  204.370697] pgd = c0004000
    [  204.373443] [0000000c] *pgd=00000000
    [  204.378601] Internal error: Oops: 17 [#1] PREEMPT
    [  204.383361] Modules linked in: vfat fat rfcomm sco l2cap sd_mod scsi_mod iphb pvr2d drm omaplfb ps
    [  204.438537] CPU: 0    Not tainted  (2.6.28-maemo2 #1)
    [  204.443664] PC is at klist_put+0x2c/0xb4
    [  204.447601] LR is at klist_put+0x18/0xb4
    [  204.451568] pc : [<c0270f08>]    lr : [<c0270ef4>]    psr: a0000113
    [  204.451568] sp : cf1b3f10  ip : cf1b3f10  fp : cf1b3f2c
    [  204.463104] r10: 00000000  r9 : 00000000  r8 : bf08029c
    [  204.468353] r7 : c7869200  r6 : cfbe2690  r5 : c78692c8  r4 : 00000001
    [  204.474945] r3 : 00000001  r2 : cf1b2000  r1 : 00000001  r0 : 00000000
    [  204.481506] Flags: NzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM Segment kernel
    [  204.488861] Control: 10c5387d  Table: 887fc018  DAC: 00000017
    [  204.494628] Process btdelconn (pid: 515, stack limit = 0xcf1b22e0)
    Signed-off-by: default avatarRoger Quadros <ext-roger.quadros@nokia.com>
    Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
    f3784d83
hci_core.h 17.6 KB